-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alfresco integration can be confusing #98
Comments
I don't see a reason to depend on external modules (OOTB) - Alfresco already provides MicroMeter metrics, so we should be exposing those IMO.
This way both Alfred Telemetry and OOTB can run in parallel, without influencing each other. |
@todorinskiz OOTB = Out Of The Box. Sorry for the confusion. |
In that case I would consider Alfresco as our central audience - let's expose our metrics to Alfresco by default. For other use cases that require reconfiguration for the monitoring system, seems reasonable to expect some learning curve there. |
cc @tgeens @thijslemmens what do you think? |
Better option is to remove complexity and just remove integration between OOTBox Alfresco metrics and Alfred Telemetry. Not try to magically integrate them. |
Since Alfresco Enterprise Edition 6.1, Alfresco records metrics using a Micrometer
PrometheusMeterRegistry
As you can see in the docs, Alfred Telemetry integrates with this out of the box Alfresco metrics:
https://github.com/xenit-eu/alfred-telemetry/tree/master/alfred-telemetry-platform/docs#alfred-telemetry-alfresco-integration
Due to this integration, it is possible to 1) expose Alfresco metrics to monitoring systems configured in Alfred Telemetry and 2) expose Alfred Telemetry metrics in the default Alfresco Prometheus endpoint.
However in practice the integration can be quite confusing for administrators.
Should we entirely remove the integration of Alfred Telemetry with OOTB (Out Of The Box) Alfresco Micrometer metrics?
The text was updated successfully, but these errors were encountered: