Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Pipelines cleanup #30

Closed
wants to merge 4 commits into from
Closed

Conversation

PapyChacal
Copy link
Collaborator

For now:

  • Simplify OpenMP pipeline (tested with MLIR, I only removed passes with absolutely no effect on the IR)
  • Use the same one for single thread, just remove the SCF->OpenMP pass. It had no impact on performance, but this removes an unnecessary dimension to performance investigations
  • Use Devito-inferred options to decide on using MPI/OpenMP. More importantly, this lift an arbitrary dependency on MPI4Py on all XDSLOperators.

@PapyChacal PapyChacal self-assigned this Oct 4, 2023
@PapyChacal PapyChacal changed the base branch from emilien/cleanup to master October 4, 2023 17:14
More importantly, this lift an arbitrary dependency on mpi4py in unrelated cases.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@PapyChacal PapyChacal changed the base branch from master to emilien/cleanup October 4, 2023 17:20
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@georgebisbas
Copy link
Collaborator

@PapyChacal is this needed?

@PapyChacal
Copy link
Collaborator Author

Not anymore, that is an old attempt at removing superfluous passes, AFAIU you redid it 🙂

@PapyChacal PapyChacal closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants