Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stencil.return operand type promotion #119

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Aug 21, 2024

Mimicing part of _ensure_same_type... Probalby would deserve refactoring before merging?

Anyway, lift another couple of xfails only triggered by that, to see clearer what remains

@PapyChacal PapyChacal self-assigned this Aug 21, 2024
Copy link
Collaborator

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review?

tests/test_xdsl_base.py Show resolved Hide resolved
@PapyChacal PapyChacal marked this pull request as ready for review August 29, 2024 14:47
@PapyChacal
Copy link
Collaborator Author

Is this ready for review?

Yep, with the open question of de we want to refactor rather than copy-pasta here!

@georgebisbas
Copy link
Collaborator

Is this ready for review?

Yep, with the open question of de we want to refactor rather than copy-pasta here!

Happy with the copy-pasta for now, we may refactor later!

@georgebisbas georgebisbas merged commit 5c31f3c into master Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants