compiler: Parametrize collapse and tiles #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
approved these changes
Jul 1, 2024
PapyChacal
reviewed
Jul 1, 2024
Comment on lines
+667
to
+680
| def generate_collapse_arg(num_loops: int): | ||
| """ | ||
| Generate the number of loops that will be collapsed | ||
| Resort to 1 if no number of loops is provided | ||
| """ | ||
|
|
||
| if num_loops < 1: | ||
| num_loops = 1 | ||
|
|
||
| ret_arg = "collapse=" + "".join(str(num_loops)) # noqa | ||
|
|
||
| return ret_arg | ||
|
|
||
|
|
There was a problem hiding this comment.
More a thought than a request 😉
It might be simpler to pass kwargs here and encapsulate the whole convert-scf-to-openmp pass? To later play with schedules, and other omp knobs like inner omp-vectorized loops and such
There was a problem hiding this comment.
will leave this for future fixes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.