New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify batch coordinates in tests #65

Closed

maxrjones opened this issue May 13, 2022 · 0 comments · Fixed by #66

Member

maxrjones commented May 13, 2022

For some tests the batch dimensions are checked but not the coordinates, as noted at https://github.com/pangeo-data/xbatcher/blob/34ca3f9b6acaf23b09ef140b69bc7c79d4f38feb/xbatcher/tests/test_generators.py#L167-L168 I think adding this type of verification would be helpful for preventing regressions while working on performance improvements (xref #37) and am interested in submitting a PR with this addition.

maxrjones mentioned this issue

Test against expected batch in test_batch_3d_2d_input #66

Merged

jhamman closed this as completed in #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment