CA-390512: Improved xenapi error handling #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldEV
force-pushed
the
private/geralde/CA-390512
branch
from
eeec71f
to
4a219f3
Compare
|
This looks OK to me but the information in the PR description should be in the commit message. |
In some cases we may fail to query the host CPUs due to an invalid reference, in this case we should log the failure and not add it into the list of host CPUs. In the event of a failure we receive a list of the form: ['HANDLE_INVALID', 'host_cpu', '<uuid>'] In a success we receive a dictionary which is later used to populate the number of CPUs per name but does not check that the contents of host_CPUs is a list of dictionaries.
GeraldEV
force-pushed
the
private/geralde/CA-390512
branch
from
4a219f3
to
bf7c970
Compare
rosslagerwall
approved these changes
Jul 23, 2024
ashwin9390
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we may fail to query the host CPUs due to an invalid reference, in this case we should log the failure and not add it into the list of host CPUs.
In the event of a failure we receive a list of the form:
['HANDLE_INVALID', 'host_cpu', '<uuid>']In a success we receive a dictionary which is later used to populate the number of CPUs per name but does not check that the contents of host_CPUs is a list of dictionaries.