CA-388527: Fix keyword argument order error #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous PR, in the `__init__`of `ProgressDialogue`, I put the keywork arguments after the positional arguments. But I forgot to do the same in `CommitCreate` when we construct a `ProgressDialogue` Signed-off-by: Stephen Cheng <[email protected]>
liulinC
approved these changes
Jun 7, 2024
xueqingz
approved these changes
Jun 7, 2024
minglumlu
approved these changes
Jun 7, 2024
| @@ -1203,8 +1203,8 @@ def create_sr_complete_callback(async_task, inOtherConfig): | |||
| Layout.Inst().PushDialogue(InfoDialogue(Lang("Storage Repository Creation Successful"))) | |||
|
|
|||
| Layout.Inst().PushDialogue(ProgressDialogue(async_task, messagePrefix, | |||
| create_sr_complete_callback, | |||
| inOtherConfig)) | |||
| inOtherConfig, | |||
There was a problem hiding this comment.
As a reference, this is to the change in another PR:
https://github.com/xapi-project/xsconsole/pull/42/files#diff-9dbe8093d7588f5b860a0e291387fefe3d3e5936d5580bbcf14b9dddc004c150R637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous PR, in the
__init__ofProgressDialogue, I put the keywork arguments after the positional arguments. But I forgot to do the same inCommitCreatewhen we construct aProgressDialogueTest the OnComplete callback was called: