Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply selected suggestions courtesy of darker (from black) #36

Conversation

bernhardkaindl
Copy link
Collaborator

Courtesy of the tool darker (applies black to the changes in a git diff),
here is a set of a few minor formatting suggestions it makes for #35.

This is an incremental PR for #35 (it can be merged/squashed into #35 or reviewed afterwards):

This PR only applies to the 2nd commit of #35, so it could be pulled and squashed into it:
CA-369899: Add NTP options DHCP|Default|Manual|None

I ran:

pip install darker
darker -r master -S -l 88 .

(88 columns is the default of black - take look yourself, it looks sensible to me too)

As this branch is on the same origin repo, you can e.g. run

git fetch origin
git cherry-pick aef00d4d7d73b58ef05a2a62e4fe5a9eb5adcfde
git rebase -i HEAD~3

and squash it into the commit CA-369899: Add NTP options DHCP|Default|Manual|None

Current commit:
Apply selected suggestions courtesy of darker (from black)

@GeraldEV GeraldEV merged commit 5830764 into private/geralde/CA-369899 Mar 18, 2024
2 checks passed
@bernhardkaindl bernhardkaindl deleted the private/bernhardk/CA-369899-review-darker-minimal-selected-parts branch March 18, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants