Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: handler level code refactor + a few import formating #5

Open
wants to merge 4 commits into
base: chore/binaries-removed+gitignore
Choose a base branch
from
Open

refactor: handler level code refactor + a few import formating #5

wants to merge 4 commits into from

Conversation

Pietroski
Copy link
Collaborator

@Pietroski Pietroski commented Apr 24, 2024 •
edited
Loading

It refactors how and where the handling layer is at the repository level to a more "standard" pattern usually used on go repos. It also fixed some fmt (printing) wrong use cases.

@Pietroski Pietroski force-pushed the refactor/routing branch 2 times, most recently from 171e557 to 9719e99 Compare April 24, 2024 13:17
kissartisan
kissartisan approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@kissartisan kissartisan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can understand, we relocated some stuff to:

  • cmd/server -> cmd (main.go file)
  • Some cmd/server files to internal/server

This is to comply to the common patterns in Go.

One question: why fmt.Errorf is not working unlike fmt.Printf as you stated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kissartisan kissartisan kissartisan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pietroski @kissartisan @andrerfarias @joshwnj