[feature] extend string interpolation syntax to add 'json' interpolator #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def json(args: Any*): JValue = { | ||
| val strings = sc.parts.iterator | ||
| val expressions = args.iterator | ||
| var buf = new StringBuffer(strings.next) |
There was a problem hiding this comment.
This should be val buf: StringBuilder
|
Thanks jiahut! I have been considering if I wanted to support this type of String interpolation, but I'm not entirely convinced just yet. First of all, I think you will find that for almost all cases, the builders actually offer a way more compact notation, with less boilerplate. Perhaps if there is a list of examples where this clearly shows a benefit over the builders, I might be willing to pull it in. It's a cool feature, but adding cool features is not an objective. It needs to be useful as well. And I'd argue completeness is not achieved if there's no longer anything to add, but if there's no longer anything left to remove. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an easy-to-use library with handing json.
I just do my best to add a feature to make It better.