Replies: 16 comments 14 replies
-
|
We'd love to have your help! As you can probably tell, while teams generally use Java for robot programming, the vast majority of the code that does the heavy lifting is in C++. The best way to get involved is to just figure out what you are interested in working on. As with any large project, we have way more project ideas than time to work on them. It's often easiest to get started with some low hanging fruit (e.g. fixing smaller issues) to get familiar with the codebase and build tools (see this repo's many open issues), but our major project priorities for 2025 can be found here: https://github.com/orgs/wpilibsuite/projects/15/views/1. Let us know what sounds interesting for you to pick up and work on, and we can discuss further details before you get too far along. |
Beta Was this translation helpful? Give feedback.
-
|
Suppose I start by writing unit tests? That could be a great way to contribute while I learn my way around the system. What unit test framework do we use? |
Beta Was this translation helpful? Give feedback.
-
|
We currently use GoogleTest but want to transition to Catch2. |
Beta Was this translation helpful? Give feedback.
-
Here's the tracking issue: #6575 |
Beta Was this translation helpful? Give feedback.
-
|
Speaking (well, typing actually) of unit tests, I'd like my team to write them. Unfortunately, the WPI APIs link user-written code tightly to the robot, making hermetic unit testing impossible. Maybe we could address that in the future? |
Beta Was this translation helpful? Give feedback.
-
|
We do have unit test support, as the simulation HAL enables mocking at that level. See, for example, https://github.com/wpilibsuite/allwpilib/blob/main/wpilibjExamples/src/test/java/edu/wpi/first/wpilibj/examples/unittest/subsystems/IntakeTest.java; there's an few different open issues (#2476 and #5558) about adding more unit tests to examples. |
Beta Was this translation helpful? Give feedback.
-
|
Maybe I could comment the code. There appears to be a steep learning foods. |
Beta Was this translation helpful? Give feedback.
-
|
Are you talking about the code in team-facing classes? Example programs? More deep internals? |
Beta Was this translation helpful? Give feedback.
-
|
Team facing code. There's an interface -- I'll have to find it -- that has a default information that references a low level API method. Makes it tough to unit test with JUnit.
Looking at the example now.
…-- Eric
On 8/11/24 2:05 PM, Peter Johnson ***@***.***> wrote:
Are you talking about the code in team-facing classes? Example programs?
More deep internals?
—
Reply to this email directly, view it on GitHub
<#6945 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD6QNGZI6J3G4LVLFNDEBUDZQ6RVRAVCNFSM6AAAAABMK4S6FGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMZQGY4TCNI>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
What in team facing code isn't documented? All user facing APIs should be documented as enforced by CI |
Beta Was this translation helpful? Give feedback.
-
|
It turns out that Eclipse is not useful. Suggestions welcome. In the meantime, running sudo cmake --build . --target install from my local git repository yielded: [ 22%] Built target wpimath_jar I'll try to track the problem down tomorrow. Advice would be most welcome. |
Beta Was this translation helpful? Give feedback.
-
|
When building with CMake, the protobuf libraries are expected to be available on your system. Please see https://github.com/wpilibsuite/allwpilib/blob/main/README-CMAKE.md for information on prerequisites for the CMake build. |
Beta Was this translation helpful? Give feedback.
-
|
Also, one thing those instructions don't currently say is to use Ninja instead of make; I've heard some reported issues with make not being able to successfully build, and all of our CI builds use ninja. |
Beta Was this translation helpful? Give feedback.
-
|
Ninja is also wayyyyyy faster |
Beta Was this translation helpful? Give feedback.
-
Says that now :) |
Beta Was this translation helpful? Give feedback.
-
|
Hi. I'm away. Can I please respond when I return?
Thanks.
…On Mon, Aug 19, 2024 at 9:59 PM Jade ***@***.***> wrote:
Also, one thing those instructions don't currently say is to use Ninja
instead of make; I've heard some reported issues with make not being able
to successfully build, and all of our CI builds use ninja.
Says that now :)
—
Reply to this email directly, view it on GitHub
<#6945 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6QNG6FASF6TWBCKVEKWXDZSKPGRAVCNFSM6AAAAABMK4S6FGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMZZGAYTANY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
I'm back and will work on the code. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, I am still encountering problems. I installed Ninja and sccache, and verified that OpenCV is installed and accessible. Here's what happened next: ric@mighty-wurlitzer: I'm sorry to keep pestering you, but it appears that CMakeCache.txt appears to be the cause. |
Beta Was this translation helpful? Give feedback.
-
|
Update: here are all occurrences of CMakeCache.txt. Should I delete them all? eric@mighty-wurlitzer: |
Beta Was this translation helpful? Give feedback.
-
|
The problem is when you first ran CMake, you used Make as the generator. Since you're switching to Ninja, you need to regenerate the build files, either by running CMake with the |
Beta Was this translation helpful? Give feedback.
-
|
I ended up building everything with Gradle. I think I'm in business. Build summary is: 29 tests completed, 5 failed
FAILURE: Build failed with an exception.
BUILD FAILED in 35m 51s |
Beta Was this translation helpful? Give feedback.
-
|
That epilogue test failure is weird. Could you post more details? Maybe something from the console, or something from the test report? |
Beta Was this translation helpful? Give feedback.
-
|
Hi,
The tests appear to fail because I am using Java 21 instead of Java 17.
I use OpenJDK. Do I have to downgrade?
…On Fri, Sep 20, 2024 at 8:34 PM Gold856 ***@***.***> wrote:
That epilogue test failure is weird. Could you post more details? Maybe
something from the console, or something from the test report?
—
Reply to this email directly, view it on GitHub
<#6945 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6QNGYH4VPXTAJQJHWB6MLZXS5JHAVCNFSM6AAAAABMK4S6FGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTANZRGAZTGOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Java 21 should be fine. It's hard to figure out what the issue is without any information about how the tests are failing. Please post more details, like an error from the console, or maybe a summary from a test report. That will make it easier to solve the test failures. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry to bother everyone, but I am a Git N00B and want to make sure that I do The Right Thing. I'd like to create a branch, say mintz-eric/fix-failing-emitter-test, fix the test (I hope), and moot the changes for inspection. Would this be OK?
Also, what IDE, if any, do you recommend? I prefer IntelliJ for Java simply because I know its quirks, but I want to conform to group norms.
Please stay safe, well, and dry.
…On 9/26/24 2:22 PM, Eric Mintz ***@***.***> wrote:
I think that I found the culprit:
https://github.com/wpilibsuite/allwpilib/blob/main/epilogue-processor/src/main/java/edu/wpi/first/epilogue/processor/AnnotationProcessor.java#L40
which reads:
@SupportedSourceVersion(SourceVersion.RELEASE_17)
This appears to be a known issue, e.g. here
<https://stackoverflow.com/questions/33554512/how-to-prevent-netbeans-supported-source-version-build-warnings-for-java-8-app>, and more generally here <https://www.google.com/search?q=%22Supported+source+version%22+%22less+than+-source%22&oq=%22Supported+source+version%22+%22less+than+-source%22&gs_lcrp=EgZjaHJvbWUyBggAEEUYOTIHCAEQIRiPAjIHCAIQIRiPAtIBCTE2Mzc1ajBqN6gCALACAA&sourceid=chrome&ie=UTF-8>.
Sorry, gotta go. The team needs me.
-- E
On 9/26/24 13:51, Eric Mintz wrote:
>
> Again, I apologize for my tardy response. Our team is frantically
> preparing for Robocon <https://www.roboconnj.org/>. Also, I am new to
> gradle and need time to learn to use it.
>
> I finally determined how to run the epilogue processor tests in
> isolation: ./gradlew :epilogue-processor:test. All I see on the
> console is:
>
>
>
>
> On 9/24/24 12:53, Eric Mintz wrote:
>>
>> I've been trying to reproduce the failure without success, probably
>> because I've never used Gradle before. Output from ./gradlew
>> testDesktopJava attached. Will keep trying.
>>
>> Thanks.
>>
>> -- Eric
>>
>> On 9/24/24 12:34, Eric Mintz wrote:
>>>
>>> Sorry to respond so slowly. I've been helping the team prepare for
>>> Robocon <https://www.roboconnj.org/>.
>>>
>>> On 9/20/24 20:34, Gold856 wrote:
>>>>
>>>> That epilogue test failure is weird. Could you post more details?
>>>> Maybe something from the console, or something from the test report?
>>>>
>>>> —
>>>> Reply to this email directly, view it on GitHub
>>>> <#6945 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD6QNGYH4VPXTAJQJHWB6MLZXS5JHAVCNFSM6AAAAABMK4S6FGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTANZRGAZTGOA>.
>>>> You are receiving this because you authored the thread.Message ID:
>>>> ***@***.***>
>>>>
|
Beta Was this translation helpful? Give feedback.
-
|
Yes, the typical approach is to create a branch ( I personally use vscode. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, Peter,
Haven't heard from you in a while. I'd like to post the test fix. Any
thoughts on granting me written permission?
Thanks,
Eric
…On Thu, Oct 3, 2024, 10:32 Eric Mintz ***@***.***> wrote:
Hi,
I think that I need permission to push. My lack of Git experience makes me
dangerous, so please grant *de minimus*. Also, if you could please
nominate reviewers, it would save me a deal of faffing about.
Thanks so much. I hope that you like the proposed changes.
Excitedly,
Eric
On 10/2/24 15:18, Peter Johnson wrote:
Yes, the typical approach is to create a branch (git checkout -b
branchname), make changes, commit, push the commit(s) to the branch on
your fork, and open a PR from there.
—
Reply to this email directly, view it on GitHub
<#6945 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6QNGZEH7PYWJCEUGHIGCDZZRBJBAVCNFSM6AAAAABMK4S6FGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAOBSGQ2TMMQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
We don't do branches in the wpilibsuite repo. The way to do it is to fork allwpilib to your account, make a branch there with the changes, and then PR those changes into this repo. |
Beta Was this translation helpful? Give feedback.
-
|
Will do. Sorry I missed that.
…On Tue, Oct 8, 2024, 15:08 Thad House ***@***.***> wrote:
We don't do branches in the wpilibsuite repo. The way to do it is to fork
allwpilib to your account, make a branch there with the changes, and then
PR those changes into this repo.
—
Reply to this email directly, view it on GitHub
<#6945 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6QNG2XHYY5VBNK6INQHZDZ2QUTDAVCNFSM6AAAAABMK4S6FGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAOBYGQZDEOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
I think I just sent the change for review. Please let me know what else I need to do.
Again, sorry for the delay. Life has been up and down of late.
…On 10/8/24 9:10 PM, Eric New Jersey ***@***.***> wrote:
Will do. Sorry I missed that.
On Tue, Oct 8, 2024, 15:08 Thad House ***@***.***
***@***.***>> wrote:
We don't do branches in the wpilibsuite repo. The way to do it is to
fork allwpilib to your account, make a branch there with the
changes, and then PR those changes into this repo.
—
Reply to this email directly, view it on GitHub
<#6945 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD6QNG2XHYY5VBNK6INQHZDZ2QUTDAVCNFSM6AAAAABMK4S6FGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAOBYGQZDEOA>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
Dear WPILib Maintainers,
Thank you for all your good work. I mentor FRC Team 7587,
Metuchen Momentum, and would like to join the maintainers. I've written software since 1964, and I'm sure that there's something for me to do. I've attached my resume to give you an idea of my capabilities.
Your sincerely,
Eric Mintz
Eric-Mintz-07-Feb-2023.pdf
Beta Was this translation helpful? Give feedback.
All reactions