Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS styling suggestions #42

Open
hedgefield opened this issue Jun 16, 2017 · 3 comments
Open

CSS styling suggestions #42

hedgefield opened this issue Jun 16, 2017 · 3 comments

Comments

@hedgefield
Copy link

I'm really digging the new way to present the information on the Settings pages, but visually I got a bit of a cluttered, disjointed feeling from glancing over the page. It's hard to describe, but it felt like it was hard to grasp what belonged together, a sort of mental noise. So I tweaked some CSS to see if I could get rid of that feeling. Tell me what you think:

general_settings_ wordpress_develop _wordpress

  • I simplified the padding on settings-field-title to 5px 0 (from 5px 10px 10px 0) to pull the fields and their titles closer together
  • I moved the descriptions above the input fields. This makes more sense to me, reading the instruction before you fill something in. It also makes the inputs feel more like 'blocks', which helps with scanning and reduces the mental noise between fields.
  • One other thing I struggled with is the white space between sections. It didn't so much separate sections as made it feel like the spacing was inconsistent, particularly also because it was used within sections (site title, tagline, then whitespace, wordpress address, site address, whitespace etc). So as an experiment I put a border between the sections, and for me that really helps. (It's border-top: 1px solid #cccccc; with margin-bottom reduced to 30px)
@joyously
Copy link

I got that feeling too, and wouldn't know what to call it.
This looks better to me.

@felixarntz
Copy link
Contributor

The layout appears more clear to me as well with your changes - great! I like the idea of moving descriptions above the inputs in particular. While it is a bit different from what we're used to, I think it makes sense for the reading flow.

More feedback from an actual designer would be much appreciated.

@afercia
Copy link
Contributor

afercia commented Jun 21, 2017

Definitely something worth experimenting :) I'd just suggest to consider a max-length for long lines of text. Ideally, for better readability they shouldn't exceed ~80 characters. See also https://core.trac.wordpress.org/ticket/34991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants