Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of the SQLite plugin #214

Merged

Conversation

jeroenpf
Copy link
Contributor

@jeroenpf jeroenpf commented Jul 24, 2024

This PR updates the version of SQLite that is used during the tests. The current version is outdated and is missing various updates and fixes.

Work that is done on the db command depends on a later version of the SQLite integration plugin.

@jeroenpf jeroenpf requested a review from a team as a code owner July 24, 2024 11:09
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We did use the current stable version in the past, but it had issues on older PHP versions. See #195

If it is more stable now, we should consider changing back to always using the latest. Looks like the plugin now finally runs PHPUnit tests on a variety of PHP versions, so that's promising already.

@swissspidy swissspidy added this to the 4.3.1 milestone Jul 24, 2024
@swissspidy swissspidy merged commit 4d4c920 into wp-cli:main Jul 24, 2024
42 checks passed
@jeroenpf
Copy link
Contributor Author

@swissspidy thanks for merging this PR! Would it be possible to have a new release for this so it can be used in the tests?

@swissspidy
Copy link
Member

Of course! ✅ Just tagged v4.3.1

@swissspidy
Copy link
Member

@jeroenpf Want to bump it again to v2.1.12? Or trying to switch back to latest?

@jeroenpf
Copy link
Contributor Author

@swissspidy Sure, I've created a PR for this: #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants