Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #100

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix failing tests #100

merged 1 commit into from
Aug 7, 2024

Conversation

ernilambar
Copy link
Member

No description provided.

@ernilambar
Copy link
Member Author

Only SQLite tests are failing. May be due to wp-cli/wp-cli-tests#214 ?

CC @swissspidy

@swissspidy
Copy link
Member

@ernilambar They are known to fail, see #92

@ernilambar ernilambar closed this Aug 6, 2024
@swissspidy swissspidy deleted the fix/failing-tests branch August 6, 2024 10:18
@swissspidy
Copy link
Member

But the failing MySQL tests still need to be addressed, no? 🤔

@ernilambar
Copy link
Member Author

wp config set DISABLE_WP_CRON true --raw was recently added and I have no understanding why it was added. I was testing whether that would fix the issue. After few digging I found that DISABLE_WP_CRON is defined in wp-cli-tests itself. So I am not sure what is the actual fix for the issue.

@swissspidy swissspidy restored the fix/failing-tests branch August 6, 2024 10:58
@swissspidy swissspidy reopened this Aug 6, 2024
@swissspidy
Copy link
Member

Seems like a mistake to me. Probably added because config-command was broken until yesterday. @schlessera can we revert that?

@schlessera schlessera marked this pull request as ready for review August 7, 2024 05:55
@schlessera schlessera requested a review from a team as a code owner August 7, 2024 05:55
@schlessera schlessera merged commit 6213dcc into main Aug 7, 2024
50 of 68 checks passed
@schlessera schlessera deleted the fix/failing-tests branch August 7, 2024 05:55
@schlessera schlessera added this to the 2.2.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants