Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar formatting bug #1

Open
spaceflows opened this issue Mar 1, 2021 · 11 comments
Open

Calendar formatting bug #1

spaceflows opened this issue Mar 1, 2021 · 11 comments
Labels
Type: UX Issue with the user experience.

Comments

@spaceflows
Copy link

World Anvil Username: Spaceflows

World / Campaign / RPG Character / Manuscript Title: Chronicles of Vorimborn / Myrkul's Sanctuary / RPG Character NA / Vorimborn

Feature: Calendar

Related URLS (add URLs of the pages that do not work!): https://www.worldanvil.com/w/the-chronicles-of-vorimborn-spaceflows/a/vorimborn-calendar-article

Describe the bug
Calendar formatting not displaying correctly. Events blocked by moon icons. CSS code displaying on certain days. The letter "i" appears on several dates. Some borders of the days of the the week have unusual formatting. Calendar was functioning normally several months ago, I have made no changes since that time.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.worldanvil.com/w/the-chronicles-of-vorimborn-spaceflows/a/vorimborn-calendar-article
  2. Click on anything
  3. Scroll down to the calendar
  4. See errors

Expected behavior
The calendar should display normal formatting, without blocked or unusual icons, nor CSS code blocks visible.

Screenshots
If applicable, add screenshots to help explain your problem. You can add screenshots by drag & drop into this window!
Screen Shot 2021-03-01 at 5 19 25 AM

@iamromeo
Copy link

iamromeo commented Mar 2, 2021

The page or world (and page) are private) From the looks of it this is an issue of lack of width and amount of content.

@spaceflows
Copy link
Author

spaceflows commented Mar 2, 2021

I have made the page public. The last I worked on it, several months ago, the formatting looked good. I have not visited the page since that time, nor have any changes been made since that time.

For example: That "morningstar" calendar id- code block I can't delete, even when I delete it, it keeps returning. Originally, there was only one citation on that day.

@Kordishal
Copy link
Collaborator

Hi, the page will remain private as long as the world is private.

For the morning star issue it is possible that the security filter deletes something important. Try just adding the title and changing the title to see if the issue is resolved.

@spaceflows
Copy link
Author

Hi. I've set the world to "public" so that you may have access.

@spaceflows
Copy link
Author

I attempted to add the title and change the title. Now nothing, no calendar at all, shows in the output.

@Kordishal
Copy link
Collaborator

Uncaught TypeError: calendar.metadata.months[month] is undefined
    addEventToDate https://www.worldanvil.com/js/global/calendar.js?v=01523:53
    convertEventsToDates https://www.worldanvil.com/js/global/calendar.js?v=01523:64
    each jQuery
    convertEventsToDates https://www.worldanvil.com/js/global/calendar.js?v=01523:55
    success https://www.worldanvil.com/js/global/calendar.js?v=01523:6
    jQuery 4

This is the error message now on the calendar @iamromeo

Can you export the calendar and send it to me on Discord via DM? SoulLink#3294 (there are two SoulLinks on the server)

@spaceflows
Copy link
Author

Are you asking me or iamromeo to DM you on Discord?

@Kordishal
Copy link
Collaborator

Kordishal commented Mar 2, 2021

You. :) I'll delete it once we figured out the issue.

@spaceflows
Copy link
Author

spaceflows commented Mar 2, 2021

Gotcha! Cool. thanks! Will do.

@Kordishal
Copy link
Collaborator

The issue with the Morning Star event is caused by HTML icon definitions. When copy pasting from fontawesome and inserting <i class="fad fa-search"></i> instead of just fad fa-search. The event is broken. But when loading up the event it is no longer possible to remove it incorrectly parses only the class names without the HTML. Which leads the HTMl to leak into the ID and other fields. Which in turn means that new events are created instead of old ones being edited. So the only way to resolve the issue is to export, edit the JSON and then import again.

At least that's what I think happened there. Might be worth it to put in a safe guard against this.

@Kordishal
Copy link
Collaborator

And the calendar stopped working because the notes field (which are the events) contained null values. No idea how they got there though.

@GorkamWorka GorkamWorka transferred this issue from another repository Mar 16, 2021
@Kordishal Kordishal added the Type: UX Issue with the user experience. label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: UX Issue with the user experience.
Projects
None yet
Development

No branches or pull requests

3 participants