Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reviewer Teams #18

Open
ksatirli opened this issue Oct 9, 2023 · 0 comments
Open

Add Reviewer Teams #18

ksatirli opened this issue Oct 9, 2023 · 0 comments
Assignees
@ksatirli
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ksatirli
Copy link
Member

ksatirli commented Oct 9, 2023

To make code reviews simpler, it would be useful to have aliases for reviewer teams.

The first two teams that come to mind:

  • Nomad / Nomad Pack
  • Terraform

These teams should be built around var.organization_members. The list(string) should turn into a list of objects, where each name also gets assigned an optional skills field (of type list(string)).

This list can then be iterated in teams.tf and mapped acccordingly.
@ksatirli ksatirli added enhancement New feature or request help wanted Extra attention is needed labels Oct 9, 2023
@ksatirli ksatirli self-assigned this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksatirli ksatirli

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ksatirli