-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Gamepads demo #88
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reopening
I made workbenchdev/Workbench#915 to explain to users how to add the --device=all
or --device=input
permission which we need before landing this.
Co-authored-by: Sonny <[email protected]>
…into gamepads-demo
"category": "controls", | ||
"description": "Respond to gamepads and controllers input", | ||
"panels": ["code", "preview"], | ||
"autorun": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"autorun": true | |
"autorun": true, | |
"flatpak-finish-args": ["--device=input"] |
title: _("Please connect a gamepad"); | ||
description: _("A controller is needed for this demo"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use normal title/description from main.json
and move the status/troubleshooting inside the status page
Adw.StatusPage status_page { | ||
title: _("Please connect a gamepad"); | ||
description: _("A controller is needed for this demo"); | ||
icon-name: "gamepad-symbolic"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon is missing - please check the Library entry "Using Icons" on how to include one in the demo
This is the same demo from this pr with no manifest changes. It might need a little cleanup, haven't touched it in awhile.