Open File: Add filter example

[Sahil-Shadwal]

Fixes #4

[sonnyp]

There is no point in having so many filters.

I think a good demonstration would be to add a new button below "Open Multiple Files" that says "Open Image" with the filter for image files

[Sahil-Shadwal]

I don't think we would be needing another button , it's fine. We can just add text , image audio and video filter. But if you say I can add a button specially for image .

[sonnyp]

You have presented no argument that would make me change my mind :)

[Sahil-Shadwal]

Screencast from 2024-01-16 10-23-25.webm
I mean this looks good , demonstrating the use of filter according too their needs. If we specify a button saying image filter wont it beat the point of adding the filters if there are not options.

[Sahil-Shadwal]

[sonnyp]

The filter is for the app not for the user.
It's a way for the app to restrict the type of file to open.

For example a social media app would have an option to share an image. Zip files wouldn't work so you restrict the file picker to images only.

There is no case where an app would filter with the options you proposed instead of accepting any file.

[Sahil-Shadwal]

Sorry for the misunderstanding, so should i add the image filter button below open multiple files?

[sonnyp]

sounds good

[Sahil-Shadwal]

Is this alright ?

[sonnyp]

Please follow my suggestion - "Open Image"

[Sahil-Shadwal]

Did the changes u asked for , and sorry for being another Jr. Developer.
Please review it whenever u get the time .

[sonnyp]

Looks good, please also update the Vala and Python code.

[Sahil-Shadwal]

Yup, will do . Thanks

[Sahil-Shadwal]

Updated the code for vala and python .