Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port 'Contex Menu' demo to Vala #34

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Port 'Contex Menu' demo to Vala #34

merged 2 commits into from
Dec 15, 2023

Conversation

UrtsiSantsi
Copy link
Contributor

No description provided.

lw64
lw64 requested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@lw64 lw64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for porting this demo! Please do these corrections, otherwise it looks good :)

demos/Context Menu/main.vala Outdated Show resolved Hide resolved
demos/Context Menu/main.vala Outdated Show resolved Hide resolved
demos/Context Menu/main.vala Outdated Show resolved Hide resolved
demos/Context Menu/main.vala Outdated Show resolved Hide resolved
demos/Context Menu/main.vala Outdated Show resolved Hide resolved
@UrtsiSantsi
Copy link
Contributor Author

I think I addressed all comments.

@UrtsiSantsi UrtsiSantsi mentioned this pull request Dec 14, 2023
Merged
@lw64 lw64 merged commit af679c4 into main Dec 15, 2023
1 check passed
@lw64 lw64 deleted the vala_context_menu2 branch December 15, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lw64 lw64 lw64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UrtsiSantsi @lw64