Port 'Animation' to Python #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandlo
reviewed
Feb 11, 2024
rolandlo
reviewed
Feb 11, 2024
rolandlo
reviewed
Feb 12, 2024
|
@UrtsiSantsi do you want to finish this one? |
|
@rolandlo would you like to take over this PR? |
Ok, I will. |
rolandlo
force-pushed
the
python_animation
branch
from
91048a4
to
4878fdb
Compare
|
@theCapypara @sonnyp This is ready for review now. The pipeline failed, but it doesn't look like the fault of this demo. I also rebased on the main branch thus solving the merge conflicts. |
|
Hi and thanks! I'm currently out of town, I'll check your changes at the end of the week, when I'm back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring animation is not working currently