Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adw.ViewSwitcherTitle is deprecated #42

Closed
sonnyp opened this issue Dec 30, 2023 · 4 comments
Closed

Adw.ViewSwitcherTitle is deprecated #42

sonnyp opened this issue Dec 30, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@sonnyp
Copy link
Contributor

sonnyp commented Dec 30, 2023

In the View Switcher demo, we use a deprecated feature.

We should migrate following the guide:

https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/migrating-to-breakpoints.html#replace-adwviewswitchertitle
@sonnyp sonnyp added the good first issue Good for newcomers label Dec 30, 2023
@Sahil-Shadwal
Copy link
Contributor

can i work on this ?

@sonnyp
Copy link
Contributor Author

sonnyp commented Dec 30, 2023

Sure thing

@Sahil-Shadwal Sahil-Shadwal mentioned this issue Dec 30, 2023
Closed
@Sahil-Shadwal
Copy link
Contributor

Had some doubts in PR can you please review them ?

@Sahil-Shadwal Sahil-Shadwal mentioned this issue Jan 11, 2024
Merged
@sonnyp
Copy link
Contributor Author

sonnyp commented Jan 13, 2024

Fixed by #51

@sonnyp sonnyp closed this as completed Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace AdwViewSwitcherTitle with AdwViewSwitcher
2 participants
@sonnyp @Sahil-Shadwal