Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate create_pull_request failing silently #542

Open
mokagio opened this issue Jan 31, 2024 · 1 comment
Open

Investigate create_pull_request failing silently #542

mokagio opened this issue Jan 31, 2024 · 1 comment

Comments

@mokagio
Copy link
Contributor

mokagio commented Jan 31, 2024

This build passed but no PR was created.

image
@AliSoftware
Copy link
Contributor

AliSoftware commented Feb 28, 2024

FYI: From a quick look at the fastlane source code, seems like the CreatePullRequestAction is implemented in such a way that it will return the PR url when successful… and [nil in case of errors] (as opposed to exiting with non-zero).

Which means it's assumed that one is supposed to check the return value of create_pull_request to check if it succeeded or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants