Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nullability Annotations to Java Classes] Update wordPressLintVersion to 2.0.0 #136

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Oct 24, 2023

This PR updates wordPressLintVersion to 2.0.0.


To test:

  1. Verifying that all the CI checks are successful (focus on the Lint related check and its report).
  2. Verify that the new MissingNullAnnotationOn* correctness related rules are reporting as expected. For a reference, see screenshot below:

image

Release Notes: https://github.com/wordpress-mobile/
WordPress-Lint-Android/releases/tag/2.0.0
@@ -35,7 +35,7 @@ ext {

ext {
// libs
wordpressLintVersion = '1.1.0'
wordpressLintVersion = '2.0.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: why don't we need to exclude generated files, like we did in WordPress-Android repository? https://github.com/wordpress-mobile/WordPress-Android/pull/19434/files#diff-e8b41fbc109de9b7fa37c43933345e6050e96b3c94fd279696d2adbfb9a90d38R25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question @wzieba ! 💯

Please follow this response comment of mine to understand the why. 🙏

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gotcha, thanks!

@ParaskP7 ParaskP7 merged commit 0d87402 into trunk Oct 25, 2023
8 checks passed
@ParaskP7 ParaskP7 deleted the deps/update-wordpress-lint-to-2.0.0 branch October 25, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants