Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Automate Release Publishing #21239

Open
wants to merge 3 commits into
base: iangmaia/release-on-ci-improvements
Choose a base branch
from

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Sep 17, 2024

This PR builds on top of #21229 and automates the release publishing, which means to:

  • Publish the existing draft release on GitHub (which will also have GitHub create the associated git tag, pointing to the tip of the branch)
  • If the release branch for the next version already exists, backmerge the current release into it
  • Delete the current release branch

This PR will be followed by updates to the Releases V2 tool.

This is the Android counterpart of wordpress-mobile/WordPress-iOS#23592

@iangmaia iangmaia requested a review from a team September 17, 2024 19:52
@iangmaia iangmaia self-assigned this Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21239-b0e2cf1
Commitb0e2cf1
Direct Downloadwordpress-prototype-build-pr21239-b0e2cf1.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21239-b0e2cf1
Commitb0e2cf1
Direct Downloadjetpack-prototype-build-pr21239-b0e2cf1.apk
Note: Google Login is not supported on these builds.

Comment on lines +3 to 4
# RELEASE_VERSION is passed as an environment variable passed to Buildkite by ReleasesV2.
if [[ -z "${RELEASE_VERSION}" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adopted the same approach in Simplenote Android. But I plan to follow it up with a dedicated PR to remove the env read here and make the pipeline pass it when they call the script.

I'm not arguing for it to happen here at this time, but keen to hear what you think of the approach: https://github.com/Automattic/simplenote-android/pull/1695/files#r1766347252

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also make the implementation consistent with the recent changes accessing RELEASE_VERSION in the pipeline command that we made in some iOS projects.

I think this is a good idea. It's an area where we lack some standardization.
Besides, having these scripts relying less on environment variables and having those explicit in the pipelines make things clearer and easier to follow.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants