Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit image usage in local backend #3997

Open
3 tasks done
zc-devs opened this issue Aug 1, 2024 · 2 comments
Open
3 tasks done

Prohibit image usage in local backend #3997

zc-devs opened this issue Aug 1, 2024 · 2 comments
Labels
backend/local breaking will break existing installations if no manual action happens schema

Comments

@zc-devs
Copy link
Contributor

zc-devs commented Aug 1, 2024

Clear and concise description of the problem

Currently, image clause is used as a path to the executable.

Suggested solution

Use entrypoint or introduce new special clause for Local backend.

Alternative

Get rid of image and use only commands.

Additional context

#3263 (reply in thread) (point N3)

Validations

  • Checked that the feature isn't part of the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@zc-devs zc-devs added the feature add new functionality label Aug 1, 2024
@zc-devs zc-devs changed the title Prohibit image usage in local backend Prohibit image usage in local backend (v3) Aug 1, 2024
@qwerty287
Copy link
Contributor

This needs a depreciation first, can't be removed in 3.0 directly.

Also, something to note: the schema currently says the image is required. We would need to drop that and that makes it less helpful cod linting.

Get rid of image and use only commands.

This should not be done because you can't use a command like export x=y then anymore.

@qwerty287 qwerty287 added breaking will break existing installations if no manual action happens backend/local schema and removed feature add new functionality labels Aug 1, 2024
@zc-devs
Copy link
Contributor Author

zc-devs commented Aug 1, 2024

This needs a depreciation first, can't be removed in 3.0 directly

Sad, but OK.

The main point is to get rid of confusing image. Do something like environment was removed from plugins and schema was corrected (#3909).
So, there is entrypoint for shell and commands for whatever else, then.

@zc-devs zc-devs changed the title Prohibit image usage in local backend (v3) Prohibit image usage in local backend Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/local breaking will break existing installations if no manual action happens schema
Projects
None yet
Development

No branches or pull requests

2 participants