Unable to use Gitea OAuth

[stepanpelc]

Component

server

Describe the bug

During integration with Gitea (v1.21.4 - latest stable) I encountered impossibility to successfully establish connection between these tools (Gitea and Woodpecker-server)

Testing was done on fresh install of Gitea as well as fresh install of Woodpecker-server using single binaries in Go.

All secrets down are just for testing not used in production.

System Info

Ubuntu 22.04 LTS - amd64 platform, fresh install

woodpecker-server - version 2.3.0, amd64, single Go binary

gitea - version 1.21.4, amd64, single Go binary

Additional context

Woodpecker-server .env file

WOODPECKER_OPEN=true
WOODPECKER_HOST=http://{{woodpecker-server_ip}
WOODPECKER_SERVER_ADDR=:80
WOODPECKER_GITEA=true
WOODPECKER_GITEA_URL=http://{{gitea_ip}}
WOODPECKER_GITEA_CLIENT=6b9afe7b-3762-47ac-9229-215132a632b7
WODDPECKER_GITEA_SECRET=gto_qppqoqkhni2ygpvqnlzdc6rbpnsttwxw6oyx46hx56hmw2f3h26q
WOODPECKER_LOG_LEVEL=debug
WOODPECKER_GITEA_SKIP_VERIFY=true
WOODPECKER_ADMIN=testadmin

Gitea Config

Error from Woodpecker-server debug log

9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/api/stream.go:82 > user feed: connection closed
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=471058.889328 method=GET path=/api/stream/events status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.106724 method=GET path=/login status=303 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.094983 method=GET path=/authorize status=303 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM ERR ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/api/login.go:53 > cannot authenticate user error="oauth2: \"unauthorized_client\" \"invalid empty client secret\""
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=846.891801 method=GET path=/authorize status=303 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.039107 method=GET path=/login status=303 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.044988 method=GET path=/login/error status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.240156 method=GET path=/web-config.js status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.039593 method=GET path=/assets/custom.css status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.078753 method=GET path=/assets/custom.js status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/api/stream.go:63 > user feed: connection opened

Error from Gitea debug log

2024/02/01 21:47:46 ...eb/routing/logger.go:102:func1() [I] router: completed GET /login/oauth/authorize?client_id=6b9afe7b-3762-47ac-9229-215132a632b7&redirect_uri=http%3A%2F%2F{{woodpecker-server_ip}}%2Fauthorize&response_type=code&state=woodpecker for {{router_ip}}:53446, 303 See Other in 199.0ms @ auth/oauth.go:362(auth.AuthorizeOAuth)
2024/02/01 21:47:46 ...eb/routing/logger.go:102:func1() [I] router: completed POST /login/oauth/access_token for {{router_ip}}:45254, 400 Bad Request in 442.7ms @ auth/oauth.go:618(auth.AccessTokenOAuth)
2024/02/01 21:47:47 ...eb/routing/logger.go:102:func1() [I] router: completed POST /login/oauth/access_token for {{router_ip}}:45254, 400 Bad Request in 379.7ms @ auth/oauth.go:618(auth.AccessTokenOAuth)

Validations

• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

[pat-s]

Logs says "oauth2: \"unauthorized_client\" \"invalid empty client secret\"". Does the secret/env var really exist in the container?

[stepanpelc]

Hello, yes, I have

WODDPECKER_GITEA_SECRET=gto_qppqoqkhni2ygpvqnlzdc6rbpnsttwxw6oyx46hx56hmw2f3h26q

in my woodpecker .env file

[pat-s]

Please don't post secrets in public, even if it's a throwaway one...

The question was: does the env var also exist in the container? Please exec into the container and run print env. Did you reference/place .env accordingly?

[zc-devs]

Could you describe step by step OAuth2 Application creation in Gitea and Login in Woodpecker flows? Like this:

• I go to that menu, then this submenu. I click something button. Then in field name I put this string. Then save button...
• I go to this address in Woodpecker. Click on that. In that field I put this and in next I put that. Then I see this confirmation...

[qwerty287]

closing as no response from opener within a month, please comment if you still have issues