Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The validator is not called unless "-s CL_VAL_PARAM=" is given #13

Open
hujiajie opened this issue Dec 4, 2014 · 1 comment
Open

The validator is not called unless "-s CL_VAL_PARAM=" is given #13

hujiajie opened this issue Dec 4, 2014 · 1 comment

Comments

@hujiajie
Copy link

hujiajie commented Dec 4, 2014

The README says

If you build a sample using settings -s CL_VALIDATOR=1, automaticaly all the .cl file embedded are modify by the validator. You can specify parameter to the webcl-validator using -s CL_VAL_PARAM='["-DPARAM1","-DPARAM2"]'.

This leads me to think that CL_VAL_PARAM is optional. But actually according to this line, the validator will not be called unless -s CL_VAL_PARAM='[""]' or -s CL_VAL_PARAM='["-DPARAM1","-DPARAM2"]' is given. The quote mark in [""] is not negligible either.

@wolfviking0
Copy link
Owner

Hi,
I push a quick fix for support only -s CL_VALIDATOR=1 without -s CL_VAL_PARAM='[""]'
Let me know if it's working for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants