Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfictl check update github release checker should support full semver for pre-releases #960

Open
pnasrat opened this issue Jun 17, 2024 · 1 comment
Labels
enhancement New feature or request needs-triage applied to all new customer/user issues. Removed after triage occurs.

Comments

@pnasrat
Copy link
Member

pnasrat commented Jun 17, 2024

For example Python PEP 440 uses pre-release identfiers including a and b

These are compatible with semver but not excluded when wolfictl check update is run

Currently the githubrelease checker uses []string{"alpha", "beta", "rc", "pre"}

invalid := []string{"alpha", "beta", "rc", "pre"}

Semver defines pre-releases as

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric identifiers MUST NOT include leading zeroes.

@pnasrat pnasrat added enhancement New feature or request needs-triage applied to all new customer/user issues. Removed after triage occurs. labels Jun 17, 2024
@luhring
Copy link
Contributor

luhring commented Jun 17, 2024

cc: @rawlingsj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage applied to all new customer/user issues. Removed after triage occurs.
Projects
None yet
Development

No branches or pull requests

2 participants