Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfictl bump fails if epoch line has comment #1282

Open
smoser opened this issue Oct 30, 2024 · 0 comments
Open

wolfictl bump fails if epoch line has comment #1282

smoser opened this issue Oct 30, 2024 · 0 comments
Labels
bug Something isn't working needs-triage applied to all new customer/user issues. Removed after triage occurs.

Comments

@smoser
Copy link
Member

smoser commented Oct 30, 2024

wolfictl bump will fail if the epoch line has a comment. Currently failing on wolfi-dev/os main in php-8.3-amqp.yaml as shown below.

$ wolfictl version | grep "^[A-Z]"                         
GitVersion:    devel
GitCommit:     1fceb4d28ca010fedb891791daab9422786df5e7
GitTreeState:  dirty
BuildDate:     2024-10-26T03:36:43
GoVersion:     go1.23.2
Compiler:      gc
Platform:      linux/amd64

$ git remote -v | grep upstream.*fetch
upstream        [email protected]:wolfi-dev/os (fetch)

$ git checkout upstream/main                              
HEAD is now at c927d988a confluent-kafka/8.0.0.48 package update (#32316)

$ wolfictl bump php-8.2-amqp.yaml 
bumping php-8.2-amqp-2.1.2-1 in php-8.2-amqp.yaml to epoch 2

$ wolfictl bump php-8.3-amqp.yaml                          
bumping php-8.3-amqp-2.1.2-1 in php-8.3-amqp.yaml to epoch 2
Error: unable to find epoch tag in yaml config
2024/10/30 09:45:30 ERRO unable to find epoch tag in yaml config

$ diff -u php-8.2-amqp.yaml php-8.3-amqp.yaml  | head -n 10
--- php-8.2-amqp.yaml
+++ php-8.3-amqp.yaml
@@ -1,15 +1,17 @@
 package:
-  name: php-8.2-amqp
+  name: php-8.3-amqp
   version: 2.1.2
-  epoch: 2
+  epoch: 1 # NB intentionally meant to be picked over previous php-amqp
   description: "PHP extension to communicate with any AMQP compliant server"

@smoser smoser added bug Something isn't working needs-triage applied to all new customer/user issues. Removed after triage occurs. labels Oct 30, 2024
smoser added a commit to wolfi-dev/os that referenced this issue Oct 30, 2024
…iles. (#32344)

Update the php-8.*-*.yaml files to have use a var transform based on
package name for the php version, and then use replace any use of php
version with that variable.

Also here:
 * drop a comment that causes issue with wolfictl bump 
   wolfi-dev/wolfictl#1282
 * update to use pecl/install and pecl/phpize pipeline where possible
* update php8.*-redis.yaml to use phpMM name, as it had already used
php-version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage applied to all new customer/user issues. Removed after triage occurs.
Projects
None yet
Development

No branches or pull requests

1 participant