Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jitsucom-jitsu/2.8.3 package update #33895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Nov 12, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Nov 12, 2024
Copy link
Contributor Author

octo-sts bot commented Nov 12, 2024

Gen AI suggestions to solve the build error:

Based on the build error, it appears the patch is failing to apply cleanly to the package.json file. Here are some steps to debug and fix this issue:

  1. First, verify the patch file contents match the target file:
melange package build --interactive jitsucom-jitsu.yaml
# Inside the interactive shell:
cat upgrade-deps.patch  # Review the patch content
cat package.json       # Compare with the target file
  1. Check if the patch needs updating:
  • The patch might be outdated for version 2.8.3
  • Line numbers or context in the patch file might not match the current package.json
  • The upstream package.json might have changed since the patch was created
  1. You can recreate the patch file:
# In your local environment:
git clone https://github.com/jitsucom/jitsu
cd jitsu
git checkout jitsu2-v2.8.3
# Make your changes to package.json
git diff > new-upgrade-deps.patch
  1. Alternative approach: Instead of using a patch, you could modify the pipeline to use sed or direct file manipulation:
pipeline:
  - runs: |
      # Example: directly modify package.json
      jq '.dependencies.something = "new-version"' package.json > package.json.tmp
      mv package.json.tmp package.json
  1. Verify the expected commit hash matches the tag:
git ls-remote https://github.com/jitsucom/jitsu refs/tags/jitsu2-v2.8.3

The most likely solution is that the patch file needs to be updated to match the current version's package.json structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant