Fix clang build failures (#26276) #29550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvreeland
force-pushed
the
jvreeland/llvm-18
branch
3 times, most recently
from
1188d6e
to
033d55c
Compare
llvm-18: Right now we we're remobing the cmake modules from `/usr/lib/llvm-18/lib/cmake/llvm` and putting them in `/usr/lib/cmake/llvm` and creating some symlinks. Instead we should keep the files in the correct place where tools like `llvm-config` expect them to be and relative improts work and symlink `/usr/lib/cmake/llvm` to the correct place in `/usr/lib/llvm-18` clang-18: Remove the uneeded directives and add `-DCMAKE_PREFIX_PATH=` to specify where the full infrastrcture for llvm-18 can be found.
justinvreeland
force-pushed
the
jvreeland/llvm-18
branch
from
033d55c
to
2c8ffb6
Compare
justinvreeland
changed the title
xnox
approved these changes
Sep 27, 2024
|
elastic build not required check (waiting for build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26276