Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split output into Json, Types, Api #96

Merged
merged 12 commits into from
May 28, 2024
Merged

Split output into Json, Types, Api #96

merged 12 commits into from
May 28, 2024

Conversation

miniBill
Copy link
Collaborator

No description provided.

wolfadex
wolfadex approved these changes May 28, 2024
View reviewed changes
Copy link
Owner

@wolfadex wolfadex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run npm run test:gen? I still haven't gotten around to figuring out how to put it in the CI. If that passed then LGTM!

Base automatically changed from baseurl to fix-test May 28, 2024 15:30
@miniBill miniBill changed the base branch from fix-test to main May 28, 2024 15:31
@miniBill
Copy link
Collaborator Author

I've fixed a couple issues with the Github codegen, and it's almost passing

@wolfadex
Copy link
Owner

I've fixed a couple issues with the Github codegen, and it's almost passing

Once the tests are passing, feel free to merge

@miniBill miniBill merged commit 864db8c into main May 28, 2024
1 check passed
@miniBill miniBill deleted the nge-ep16 branch May 28, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfadex wolfadex wolfadex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miniBill @wolfadex