Cleanup client-tls-resume and add new apps to git ignore #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julek-wolfssl
requested changes
Feb 6, 2023
julek-wolfssl
requested changes
Feb 6, 2023
Comment on lines
286
to
288
| #ifdef OPENSSL_EXTRA | ||
| if (session) | ||
| wolfSSL_SESSION_free(session); |
There was a problem hiding this comment.
This shouldn't be guarded. Using get1 means that the session always has to be free'd.
There was a problem hiding this comment.
That's a NULL check. So if wolfSSL_get1_session failed, then wouldn't need to free, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a concern from ZD15600
In the resume example, the
sslstructure is already freed previously, and here we should be freeing thesslResstructure.Add newly created apps to git ignore
/dtls/client-dtls13/dtls/server-dtls13/tls/server-tls-poll-perf