Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a classifier generates broken applications #10

Open
lbane opened this issue Jul 22, 2020 · 0 comments
Open

Setting a classifier generates broken applications #10

lbane opened this issue Jul 22, 2020 · 0 comments

Comments

@lbane
Copy link
Contributor

lbane commented Jul 22, 2020

In general wolifecycle implements some kind of classifier support, but setting a classifier on a woapplication project generates incomplete and broken applications.

<build>
        <plugins>
            <plugin>
                <groupId>org.wocommunity</groupId>
                <artifactId>wolifecycle-maven-plugin</artifactId>
                <extensions>true</extensions>
                <configuration>
                    <skipAppleProvidedFrameworks>${skip.apple.frameworks}</skipAppleProvidedFrameworks>
                    <classifier>testclassifier</classifier>
                </configuration>
            </plugin>
        </plugins>
</build>

The content of the WOA build is split between two directories, one with the classifier embedded in the name (e.g. ERXTest-7.2-SNAPSHOT-testclassifier.woa), and one without the classifier (ERXTest-7.2-SNAPSHOT.woa). The classifier part contains all application resources (components, webserverresources, etc.), while the non-classifier part contains the java classes and WOA infrastructure (classpath files, start scripts).
The tgz-archives are packed and named from the WOA without the classifier, but installed and deployed under the classifier name.
In my opinion the build should generate only the non-classifier WOA directory (named after the finalName property) with all content, and only then generate the tgz-archives with the classifier name. If it is necessary to embed the classifier into the app directory name, then finalName could be modified accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant