Option to pass renderLabel prop to the RadioButton component #2565
gradisarjoze
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey.
First of all I would like to thank all the contributors for this awesome lib!
During a design implementation I came across a use case where I needed a more flexible radio button group.
Specifically, rendering a "rich" label.
Example of what was "doable" on iOS:
This was done by providing an element to the label property and surprisingly it doesn't really break much on iOS.
However, on Android, it's not working as nicely, and it shouldn't as I'm passing a View into the Text component.
After checking the code, the label is apparently only meant to be a string:
react-native-ui-lib/src/components/radioButton/index.tsx
Line 224 in 17e97ad
For the time being, I'm moving forward with a simpler checkbox. But if any of the core maintainers agree with the proposal, I'd be happy to open a PR.
Beta Was this translation helpful? Give feedback.
All reactions