Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update View Transitions Docs #8904

Open
OliverSpeir opened this issue Jul 23, 2024 · 9 comments
Open

Update View Transitions Docs #8904

OliverSpeir opened this issue Jul 23, 2024 · 9 comments
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. help wanted Issues looking for someone to run with them!

Comments

@OliverSpeir
Copy link
Contributor

OliverSpeir commented Jul 23, 2024

📋 Suggested page

https://docs.astro.build/en/guides/view-transitions/

📋 General description or bullet points (if proposing new content)

Add "Removing <ViewTransitions/> Component section

  • "What needs to change?"
  • "What can I keep?"
  • "How do I reuse my custom animations?"

Maybe add tracking of browser support, I personally will volunteer for keeping this updated

As of right now:

  • Chrome and Edge support level 2
  • Safari added level 1, I haven't found a good issue to track level 2
  • Firefox has plans for level 1 in new couple months, Bugzilla
@OliverSpeir OliverSpeir added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jul 23, 2024
@sarah11918
Copy link
Member

Great call out to document removing the component!

As for updating statuses... is there a predictable static link for checking each browser's status? I would prefer if we didn't have to ourselves literally say "Browser X, level Y support" but could have one link that never needs updating that is e.g.[current adoption status of Browser X](link we don't have to update)

Or, if some other source we trust is updating statuses, I would be OK to link to even a non-official source that we find reliable and have faith will themselves be updating.

@sarah11918 sarah11918 added the help wanted Issues looking for someone to run with them! label Jul 23, 2024
@liruifengv
Copy link
Member

How about the View Transitions API Docs In MDN?

@sarah11918
Copy link
Member

That link looks amazing, exactly what I was thinking of! 🙌

@OliverSpeir
Copy link
Contributor Author

OliverSpeir commented Jul 25, 2024

That link covers level 1 Astro needs level 2 to be able to replace the ViewTransitions component

@martrapp
Copy link
Member

martrapp commented Jul 26, 2024

Granted, mdn is currently a bit in transition between level 1 and 2 for the documentation, but liruifengv's link is fine. The startViewTransition table shows level 1 support and the @viewTransition table shows level 2 support.

@sarah11918
Copy link
Member

sarah11918 commented Jul 26, 2024

@martrapp posted his page recently https://events-3bg.pages.dev/jotter/api/references/#w3c-drafts ... would this work? (lol, Martin just commented)

@OliverSpeir
Copy link
Contributor Author

Also worth noting that we need to explain that transition persist won’t be supported by the browsers

@sarah11918
Copy link
Member

Great addition! Looking for someone to run with this and make an initial draft PR for docs!

@sarah11918
Copy link
Member

Just checking to see whether anyone is interested in picking this one up! We've got the link mentioned above for browser support, and a section on removing the component would be welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. help wanted Issues looking for someone to run with them!
Projects
None yet
Development

No branches or pull requests

4 participants