Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: [TSX] Unclosed components after a closed component are treated as comments #987

Closed
Princesseuh opened this issue Mar 21, 2024 · 1 comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: tsx Related to the TSX output (scope)

Comments

@Princesseuh
Copy link
Member

Princesseuh commented Mar 21, 2024

What version of @astrojs/compiler are you using?

^2.7.0

What package manager are you using?

pnpm

What operating system are you using?

macOS

Describe the Bug

---
---

<Component1></Component1>
<Component2

becomes

/* @jsxImportSource astro */



<Fragment>
<Component1></Component1>{`
<Component2`}
</Fragment>
export default function Card__AstroComponent_(_props: Record<string, any>): any {}

Since <Component2> is in a comment, completions don't work.

Link to Minimal Reproducible Example

https://live-astro-compiler.vercel.app/?editor-state=WzMxLDEzOSw4LDAsMTk2LDkyLDI1MiwxMDEsMiwzLDEwMSwxNDQsNzksNzksMTk1LDQ4LDEyLDE5NywxOTEsNzUsMjA2LDEwNywxMjksOTMsMTQ0LDE2Niw5LDEwNSwyNiwxMjcsMTMyLDE5NiwxLDE4MSw1LDExOCwyMTYsMTk3LDc1LDkyLDIwLDQxLDEzNywzNSwzOSwxMDEsOCwxOTYsMTE5LDE5OSwyMzcsMjE2LDg2LDE4Miw3NSwxNjQsMjE2LDE5MSwyNDcsMTU4LDIzNywxMTEsMTY1LDU5LDEwMiwxMiwxMjEsNzMsNjIsOTAsMTM1LDI1MiwxMzgsMTU2LDQ0LDUsNTMsODMsMjExLDI0MiwxODYsMTg4LDg0LDE5LDE2NSwyMDEsMTYwLDEyNCwxMzksMTYyLDg4LDEzNSwyMjUsODksMTM1LDEyMSw3OSw4MywxNiwyMTcsMjEzLDIwNSwyNTIsOTgsMjQ0LDI1LDE4MywxNjYsMTYyLDIyMSwxOCwxNTUsNTUsMTM0LDI0LDIwOSwxNjgsODksMTEsNDYsMjI1LDY4LDI0OSwxNTcsOTUsODMsMTc1LDQsMTM2LDE5Miw5LDE1OSw0MSwyMTcsNjAsMTMyLDI1NCwzMywxNTMsMzMsMTY0LDE1MCwyMTYsNjMsMTM0LDE0MCwyOCwxOTIsMTg5LDg0LDc5LDM0LDE3LDE5MCwxNDksMjUsMywyNDgsMjIyLDk2LDksMTA4LDc0LDcyLDE1Myw3MywyMzQsNjUsOTYsMTEyLDI0NiwxMSwyMDUsMjUzLDE0NSwxNDQsMjUwLDE5MywxNjksMTY2LDE0Miw1MywxMjIsMTM2LDIzMSwzMywxMzksMjIyLDIyNywxOTMsMjA5LDYsMjIwLDEzMCwyMjMsMjExLDEzNywxNzYsMjIzLDcsMTE2LDYyLDE1MSw4NSwxNTIsNTgsMTUxLDEwNyw3NywxNzgsOTIsMjM3LDIzMiw3MiwxMjQsODgsMjIwLDIyMiw5OCw2LDI1LDE5NiwyMzYsMzIsMjQxLDIwNCwyMjAsNzMsNDMsMTYxLDY3LDE1NywyMDksNTIsMTIzLDE0Nyw2LDU0LDE0Niw1NSwxNTYsMTIwLDIxMiwxNzMsODcsMjU1LDIzNCwxMzUsMjAwLDE4NywyMDcsMTM2LDEwOCwxODksMjgsMjMsOTIsMTMzLDE5MywzMiwyMTUsMTU0LDEwOSwyMjAsNzEsMjU1LDI1MiwyLDU4LDIyOSwxODAsMTAxLDIwNiwxLDAsMF0%3D

@Princesseuh Princesseuh added - P3: minor bug An edge case that only affects very specific usage (priority) feat: tsx Related to the TSX output (scope) labels Mar 21, 2024
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Mar 21, 2024
@Princesseuh Princesseuh removed the needs triage Issue needs to be triaged label Mar 21, 2024
@Princesseuh
Copy link
Member Author

I'm dumb, this is a duplicate of #862 🤦‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: tsx Related to the TSX output (scope)
Projects
None yet
Development

No branches or pull requests

1 participant