Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_isMature returns wrong value for closed stakes overtime #13

Open
vm06007 opened this issue Dec 2, 2020 · 0 comments
Open

_isMature returns wrong value for closed stakes overtime #13

vm06007 opened this issue Dec 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@vm06007
Copy link
Member

vm06007 commented Dec 2, 2020

return _stake.finalDay <= globals.currentWiseDay;

if the stake gets closed pre-maturely eventually this expression will return true once the _currentWiseDay() has reached the finalDay which will affect checkMyStakeByID() return information for UI, not critical but needs adjustment to take in account stake.closeDay to determine maturity.

function _isMatureStake(Stake memory _stake) internal view returns (bool) { return _stake.closeDay > 0 ? _stake.finalDay <= _stake.closeDay : _stake.finalDay <= _currentWiseDay(); }

as an option

@vm06007 vm06007 added the enhancement New feature or request label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant