Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use stake.closeDay or stake.isActive to detect rewardAmount #12

Open
vm06007 opened this issue Dec 1, 2020 · 0 comments
Open

use stake.closeDay or stake.isActive to detect rewardAmount #12

vm06007 opened this issue Dec 1, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@vm06007
Copy link
Member

vm06007 commented Dec 1, 2020

minor, affecting only checkStakeByID external view

wise-token-contracts/contracts/StakingToken.sol

Line 611 in fe975b5

return _stake.rewardAmount == 0 ? _detectReward(_stake) : _stake.rewardAmount;

if stake is ended pre-maturely on first/second day and there is no reward generated yet the function will try to continue calculating reward for ended stake (issue with unprocessed days and displaying data on UI)
@vm06007 vm06007 added the enhancement New feature or request label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vm06007