feat: Delete group as admin #18231
Open
feat: Delete group as admin #18231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18231 +/- ##
=======================================
Coverage 46.39% 46.40%
=======================================
Files 800 804 +4
Lines 25825 25864 +39
Branches 5887 5891 +4
=======================================
+ Hits 11982 12001 +19
- Misses 12337 12355 +18
- Partials 1506 1508 +2 |
e-maad
reviewed
Oct 29, 2024
| title: t('modalConversationDeleteGroupHeadline', conversationEntity.display_name()), | ||
| }, | ||
| }); | ||
| return new Promise(() => { |
There was a problem hiding this comment.
Not sure why we wrapped it in the promise.
We should remove it and update the update the consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding possibility to delete group for all user admins, which is in the team.
Checklist