-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Disabled enforce Countly by env variable #18175
base: dev
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
const {isDev, isEdge, isInternal, isLocalhost, isStaging, name} = getWebEnvironment(); | ||
|
||
if (isDev || isEdge || isInternal || isLocalhost || isStaging) { | ||
if (!DISABLE_ENFORCE_COUNTLY && (isDev || isEdge || isInternal || isLocalhost || isStaging)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this would achieve the same thing:
if (!DISABLE_ENFORCE_COUNTLY && (isDev || isEdge || isInternal || isLocalhost || isStaging)) { | |
if (isEdge || isInternal || isStaging) { |
We only want to enforce it on internal envs, not really dev envs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18175 +/- ##
==========================================
- Coverage 46.38% 46.37% -0.02%
==========================================
Files 796 796
Lines 25790 25790
Branches 5884 5884
==========================================
- Hits 11962 11959 -3
- Misses 12331 12334 +3
Partials 1497 1497 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be dropped.
It used the "wrong" logic, to disable enforcement via a env variable. We already changed the enforcement to use a env variable instead of in-app logic
Description
Added flag to disable enforcing Countly.
Checklist