Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: In call emoji reactions #17734

Closed
wants to merge 2 commits into from
Closed

Conversation

thisisamir98
Copy link
Contributor

Description

Screenshots/Screencast (for UI changes)

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

Copy link

sonarcloud bot commented Jul 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.

Project coverage is 46.29%. Comparing base (eb879c1) to head (7e3fe50).

Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation   #17734      +/-   ##
==================================================
- Coverage           46.33%   46.29%   -0.04%     
==================================================
  Files                 774      774              
  Lines               25193    25223      +30     
  Branches             5762     5766       +4     
==================================================
+ Hits                11672    11677       +5     
- Misses              12054    12077      +23     
- Partials             1467     1469       +2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants