Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set node version fix to 18.16 #16933

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

chore: set node version fix to 18.16 #16933

wants to merge 1 commit into from

Conversation

aweiss-dev
Copy link
Member

All Version from 18.17 on cause crypto error in our tests.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.04%. Comparing base (2d52e3a) to head (0e6dffc).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #16933   +/-   ##
=======================================
  Coverage   46.04%   46.04%           
=======================================
  Files         746      746           
  Lines       24383    24383           
  Branches     5577     5577           
=======================================
  Hits        11226    11226           
  Misses      11740    11740           
  Partials     1417     1417           

@tlebon
Copy link
Contributor

tlebon commented Mar 6, 2024

question is if this will kill our instances running in aws on node 16 🤔
i guess no if we were already set to 18

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.04%. Comparing base (2d52e3a) to head (0e6dffc).
Report is 1068 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #16933   +/-   ##
=======================================
  Coverage   46.04%   46.04%           
=======================================
  Files         746      746           
  Lines       24383    24383           
  Branches     5577     5577           
=======================================
  Hits        11226    11226           
  Misses      11740    11740           
  Partials     1417     1417           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants