Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade required node version to 18 #16534

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Jan 16, 2024

Description

Will upgrade all our CI jobs to use node v18

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb950ad) 45.43% compared to head (3c8f59e) 45.43%.
Report is 90 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #16534   +/-   ##
=======================================
  Coverage   45.43%   45.43%           
=======================================
  Files         740      740           
  Lines       24212    24212           
  Branches     5502     5502           
=======================================
  Hits        11000    11000           
  Misses      11800    11800           
  Partials     1412     1412           

@tlebon
Copy link
Contributor

tlebon commented Jan 17, 2024

fyi theres a small chance this breaks elastic beanstalk. unfortunately webapp is running on node 16 there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants