Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ngrok): reference ngrok.js as a relative path #60

Closed
wants to merge 3 commits into from
Closed

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jan 16, 2024

No description provided.

@skyrpex
Copy link
Contributor

skyrpex commented Jan 19, 2024

Yup, tried using the lib but failed..

Copy link

github-actions bot commented Feb 9, 2024

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days.
If you need help with the PR, do not hesitate to reach out in the winglang community slack at winglang.slack.com.
Feel free to re-open this PR when it is still relevant and ready to be worked on again.
Thanks!

@github-actions github-actions bot added the Stale label Feb 9, 2024
@github-actions github-actions bot removed the Stale label Feb 12, 2024
@skyrpex
Copy link
Contributor

skyrpex commented Feb 15, 2024

I think this solution won't work since __dirname is used during inflight, which is a bundled function and can't retain bundle-less info like dirname or filename.

See #79, it gathers __dirname during preflight as a solution.

@eladb
Copy link
Contributor Author

eladb commented Feb 15, 2024

Yes. I saw. Great job!

@eladb eladb closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants