Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): use sim.Container #261

Merged
merged 14 commits into from
Jun 13, 2024
Merged

chore(python): use sim.Container #261

merged 14 commits into from
Jun 13, 2024

Conversation

eladcon
Copy link
Contributor

@eladcon eladcon commented Jun 13, 2024 •
edited
Loading

Use the sim.Container to show containers logs. Also use docker image instead of local python to build the python dependencies.

staycoolcall911
staycoolcall911 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@staycoolcall911 staycoolcall911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify Mergify
Copy link

mergify bot commented Jun 13, 2024

Thanks for contributing, @eladcon! This PR will now be added to the merge queue, or immediately merged if py-use-sim-container is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 457ee3a into main Jun 13, 2024
6 checks passed
@mergify mergify bot deleted the py-use-sim-container branch June 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staycoolcall911 staycoolcall911 staycoolcall911 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eladcon @staycoolcall911