feat: bring yaml #250
Closed
feat: bring yaml #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chriscbr
reviewed
May 30, 2024
Comment on lines
+17
to
+30
| ```js | ||
| bring fs; | ||
| bring yaml; | ||
| bring cloud; | ||
|
|
||
| let file = fs.readFile("./test.yml"); | ||
| let value = yaml.parseValue(file); | ||
| yaml.stringifyValue(json); | ||
|
|
||
| new cloud.Function(inflight () => { | ||
| let value = yaml.parse(file); | ||
| yaml.stringify(json); | ||
| }); | ||
| ``` |
There was a problem hiding this comment.
We should totally include this in the built-in standard library!
There was a problem hiding this comment.
Don't we already have some yaml stuff in the standard library?
There was a problem hiding this comment.
I agree this should be part of the stdlib.
There was a problem hiding this comment.
apparently we already have fs.readYaml.. was not aware of it
eladb
requested changes
Jun 1, 2024
| indent: num?; | ||
| } | ||
|
|
||
| pub class Util { |
There was a problem hiding this comment.
what's the benefit of this duplication? Why not just make the extern methods public?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.