Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bytes type #7122

Merged
merged 6 commits into from
Sep 16, 2024
Merged

feat: bytes type #7122

merged 6 commits into from
Sep 16, 2024

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Sep 12, 2024

Closes #7118

This implements the immutable variant of bytes. The mutable version is left for future work.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@monadabot
Copy link
Contributor

monadabot commented Sep 12, 2024

Console preview environment is available at https://wing-console-pr-7122.fly.dev 🚀

Last Updated (UTC) 2024-09-16 16:34

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 13, 2024
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 13, 2024
@skyrpex
Copy link
Contributor

skyrpex commented Sep 16, 2024

Any plans on adding streaming APIs? The current methods only load entire files... what about big files that need to be processed in steps, for example?

@Chriscbr
Copy link
Contributor Author

Any plans on adding streaming APIs? The current methods only load entire files... what about big files that need to be processed in steps, for example?

I left it out of the base bytes RFC to avoid more scope creep, but I'm totally with you, Wing should data streaming (at least in inflight). I'll open an issue for further design discussion.

I think since bytes is implemented in terms of JavaScript's Uint8Array (which is supported by Node.js and browsers), any further streaming additions should be compatible with this API. But we can adjust or revisit if needed

@Chriscbr Chriscbr merged commit 6b016b1 into main Sep 16, 2024
23 checks passed
@Chriscbr Chriscbr deleted the rybickic/bytes-impl branch September 16, 2024 16:51
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bytes type
3 participants