Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (58f6cb7) and #7099 together #7102

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 10, 2024

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (58f6cb7) and #7099 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #7099.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue default for merge:

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 7099
...

skyrpex and others added 2 commits September 10, 2024 10:01
The new node version is now specified in some config files where it was missing.

Related to #7094.
@mergify mergify bot closed this Sep 10, 2024
@mergify mergify bot deleted the mergify/merge-queue/b307faf4c8 branch September 10, 2024 12:49
@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 57ms±0.69 57ms±0.72 0ms (-0.42%)⬜
functions_10.test.w -t sim 492ms±17.5 526ms±28.75 +34ms (+6.99%)🟥
functions_10.test.w -t tf-aws 2194ms±18.2 2182ms±21.91 -13ms (-0.57%)⬜
jsii_small.test.w -t sim 378ms±5.99 379ms±4.84 +0ms (+0.12%)⬜
jsii_small.test.w -t tf-aws 606ms±4.88 606ms±6.23 -1ms (-0.08%)⬜
functions_1.test.w -t sim 414ms±5.18 406ms±3.09 -8ms (-2.04%)⬜
functions_1.test.w -t tf-aws 849ms±6.55 841ms±8.54 -8ms (-0.95%)⬜
empty.test.w -t sim 374ms±2.83 370ms±3.01 -4ms (-0.94%)⬜
empty.test.w -t tf-aws 603ms±2.65 594ms±5.2 -8ms (-1.39%)⬜
hello_world.test.w -t sim 418ms±2.86 409ms±2.54 -9ms (-2.2%)⬜
hello_world.test.w -t tf-aws 1479ms±8.63 1472ms±4.41 -8ms (-0.51%)⬜
jsii_big.test.w -t sim 2954ms±15.08 2958ms±9.9 +4ms (+0.15%)⬜
jsii_big.test.w -t tf-aws 3181ms±22.04 3182ms±37.64 +2ms (+0.05%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 57ms 56ms 59ms 1ms 1ms
functions_10.test.w -t sim 526ms 492ms 605ms 29ms 40ms
functions_10.test.w -t tf-aws 2182ms 2138ms 2236ms 22ms 31ms
jsii_small.test.w -t sim 379ms 366ms 389ms 5ms 7ms
jsii_small.test.w -t tf-aws 606ms 590ms 619ms 6ms 9ms
functions_1.test.w -t sim 406ms 400ms 413ms 3ms 4ms
functions_1.test.w -t tf-aws 841ms 826ms 866ms 9ms 12ms
empty.test.w -t sim 370ms 363ms 375ms 3ms 4ms
empty.test.w -t tf-aws 594ms 584ms 607ms 5ms 7ms
hello_world.test.w -t sim 409ms 404ms 415ms 3ms 4ms
hello_world.test.w -t tf-aws 1472ms 1462ms 1481ms 4ms 6ms
jsii_big.test.w -t sim 2958ms 2935ms 2977ms 10ms 14ms
jsii_big.test.w -t tf-aws 3182ms 3130ms 3318ms 38ms 53ms
Last Updated (UTC) 2024-09-10 12:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants