Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade github actions to artifacts v4 #7027

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Aug 19, 2024

Previously attempted here and reverted here.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner August 19, 2024 22:05
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

tsuf239
tsuf239 previously approved these changes Aug 20, 2024
@tsuf239 tsuf239 dismissed their stale review August 20, 2024 06:55

thought it was a hot fix

@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-7027.fly.dev 🚀

Last Updated (UTC) 2024-08-20 14:51

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 60ms±0.97 63ms±1.92 +3ms (+4.96%)🟥
hello_world.test.w -t sim 431ms±5.72 431ms±8.34 +0ms (+0.03%)⬜
hello_world.test.w -t tf-aws 1560ms±10.26 1573ms±5.63 +13ms (+0.81%)⬜
jsii_big.test.w -t sim 3096ms±21.73 3099ms±21.19 +4ms (+0.12%)⬜
jsii_big.test.w -t tf-aws 3321ms±20.05 3297ms±12.42 -24ms (-0.72%)⬜
functions_1.test.w -t sim 428ms±7.94 424ms±4.39 -3ms (-0.74%)⬜
functions_1.test.w -t tf-aws 912ms±7.88 890ms±6.4 -22ms (-2.41%)⬜
empty.test.w -t sim 390ms±5.27 393ms±8.08 +3ms (+0.66%)⬜
empty.test.w -t tf-aws 649ms±4.58 639ms±9.45 -10ms (-1.59%)⬜
functions_10.test.w -t sim 527ms±8 526ms±16.69 -1ms (-0.22%)⬜
functions_10.test.w -t tf-aws 2318ms±14.21 2284ms±15.66 -34ms (-1.45%)⬜
jsii_small.test.w -t sim 402ms±2.85 397ms±4.64 -5ms (-1.33%)⬜
jsii_small.test.w -t tf-aws 649ms±7.71 653ms±5.24 +4ms (+0.62%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 63ms 60ms 67ms 2ms 3ms
hello_world.test.w -t sim 431ms 419ms 456ms 8ms 12ms
hello_world.test.w -t tf-aws 1573ms 1562ms 1584ms 6ms 8ms
jsii_big.test.w -t sim 3099ms 3058ms 3147ms 21ms 30ms
jsii_big.test.w -t tf-aws 3297ms 3273ms 3321ms 12ms 17ms
functions_1.test.w -t sim 424ms 416ms 435ms 4ms 6ms
functions_1.test.w -t tf-aws 890ms 879ms 906ms 6ms 9ms
empty.test.w -t sim 393ms 381ms 411ms 8ms 11ms
empty.test.w -t tf-aws 639ms 628ms 674ms 9ms 13ms
functions_10.test.w -t sim 526ms 472ms 553ms 17ms 23ms
functions_10.test.w -t tf-aws 2284ms 2245ms 2310ms 16ms 22ms
jsii_small.test.w -t sim 397ms 382ms 406ms 5ms 6ms
jsii_small.test.w -t tf-aws 653ms 643ms 669ms 5ms 7ms
Last Updated (UTC) 2024-08-20 14:57

@Chriscbr Chriscbr merged commit e8e41e9 into main Aug 20, 2024
23 checks passed
@Chriscbr Chriscbr deleted the rybickic/upgrade-actions branch August 20, 2024 15:15
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.82.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants